Add CI check for untidy go modules #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a CI check to confirm whether go modules are tidy. If they are not tidy, complain!
mflendrich
reviewed
Nov 9, 2020
|
Hack script (the copied part) now includes the suggested Apache boilerplate from https://github.com/grafana/grafana/blob/master/LICENSE#L190-L202 Modification notice after should suffice for redistribution requirement (b): https://github.com/grafana/grafana/blob/master/LICENSE#L98-L99 |
mflendrich
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a CI check to confirm whether go modules are tidy. If they are not tidy, complain!
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #917Special notes for your reviewer:
Demo failure on https://github.com/Kong/kubernetes-ingress-controller/pull/948/checks?check_run_id=1366090329
Shamelessly copy-pastaed script from grafana/grafana#27204 with minor modifications to add problem-correction instructions.