Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backendtlspolicy): enqueue for ConfigMaps #6837

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Dec 13, 2024

What this PR does / why we need it:

Enqueue BackendTLSPolicy for ConfigMaps that are referenced in spec.validation.caCertificateRefs.

Additionally, update the Accepted status condition to Invalid if the referenced ConfigMap doesn't exist or cannot be retrieved.

Which issue this PR fixes:

Related to #6633

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek added the area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API label Dec 13, 2024
@pmalek pmalek self-assigned this Dec 13, 2024
@pmalek pmalek force-pushed the backendtls-policy-enqueue-for-configmaps branch from 7bc409f to 4675bd3 Compare December 13, 2024 15:37
@pmalek pmalek marked this pull request as ready for review December 13, 2024 15:42
@pmalek pmalek requested a review from a team as a code owner December 13, 2024 15:42
@pmalek pmalek enabled auto-merge (squash) December 13, 2024 15:42
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 48.07692% with 27 lines in your changes missing coverage. Please review.

Project coverage is 77.1%. Comparing base (aeb6c54) to head (4675bd3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...controllers/gateway/backendtlspolicy_controller.go 32.5% 23 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6837     +/-   ##
=======================================
- Coverage   80.1%   77.1%   -3.1%     
=======================================
  Files        209     209             
  Lines      25178   25230     +52     
=======================================
- Hits       20192   19466    -726     
- Misses      3960    4757    +797     
+ Partials    1026    1007     -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek merged commit ae372cd into main Dec 13, 2024
42 checks passed
@pmalek pmalek deleted the backendtls-policy-enqueue-for-configmaps branch December 13, 2024 16:40
@pmalek pmalek added this to the KIC v3.4.x milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants