feat: Add the flag --secret-label-selector to set the label selector for Secrets to ingest.
#6795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5fd9b46 to
4dee51b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6795 +/- ##
=======================================
+ Coverage 77.6% 77.7% +0.1%
=======================================
Files 207 207
Lines 24644 24679 +35
=======================================
+ Hits 19131 19197 +66
+ Misses 4528 4506 -22
+ Partials 985 976 -9 ☔ View full report in Codecov by Sentry. |
randmonkey
reviewed
Dec 9, 2024
fbf6ae0 to
5cedcca
Compare
randmonkey
previously approved these changes
Dec 9, 2024
5cedcca to
0597277
Compare
randmonkey
previously approved these changes
Dec 9, 2024
pmalek
requested changes
Dec 9, 2024
df86376 to
5bc641e
Compare
5bc641e to
651d7d3
Compare
pmalek
reviewed
Dec 9, 2024
--secret-label-selector to set the label selector for Secrets to ingest.
--secret-label-selector to set the label selector for Secrets to ingest.--secret-label-selector to set the label selector for Secrets to ingest.
d058779 to
6ea2518
Compare
…crets` to ingest. By setting this flag, the secrets that are ingested will be limited to those having this label set to "true". This can reduce the memory usage in scenarios with a large number of giant secrets. Co-authored-by: Patryk Małek <patryk.malek@konghq.com> Co-authored-by: Tao Yi <tao.yi@konghq.com> Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
6ea2518 to
86a54d6
Compare
pmalek
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As #6576 mentioned, we received a report about KIC's high memory usage.
We can reproduce this issue by the following steps:
Before this change:
KIC will consume over 1G of memory within the first 3-5 minutes, but after 10 minutes, KIC's memory consumption will stay around 400M.
With this change:
KIC will consume over 1G of memory within the first 3-5 minutes, but after 10 minutes, KIC's memory consumption will stay around 360M.
Which issue this PR fixes:
fixes: #6576
Special notes for your reviewer:
In this PR, I added a
--secret-label-for-cachingflag. Users can control whether KIC should cache it by specifying a label for the secret resources.This is achieved by setting a LabelSelectorPredicate.
Of course, as I mentioned earlier, this approach only alleviates some of the memory usage pressure. A more thorough way we have is not to cache, which will greatly increase the pressure on the API server.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR