fix(fallback): backfill all affected objects, not only broken #6172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changes the backfilling algorithm to attempt to backfill all affected (broken + directly and indirectly affected) objects from the last valid state instead of only the broken ones (the ones reported by Gateway).
Also
UseLastValidConfigForFallback
flag value tosendconfig.Config
(I could swear I tested that locally E2E and it was working 🤔)EventuallyGETPath
are the expected response headers (no, they're not - these are request headers 🤦). It was passing, but wasn't really tested what it should test.Which issue this PR fixes:
Part of #5854.