Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fallback): backfill all affected objects, not only broken #6172

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Jun 7, 2024

What this PR does / why we need it:

Changes the backfilling algorithm to attempt to backfill all affected (broken + directly and indirectly affected) objects from the last valid state instead of only the broken ones (the ones reported by Gateway).

Also

  • Passes the UseLastValidConfigForFallback flag value to sendconfig.Config (I could swear I tested that locally E2E and it was working 🤔)
  • Fixes the integration test that incorrectly assumed that headers that we pass to EventuallyGETPath are the expected response headers (no, they're not - these are request headers 🤦). It was passing, but wasn't really tested what it should test.

Which issue this PR fixes:

Part of #5854.

@czeslavo czeslavo self-assigned this Jun 7, 2024
@czeslavo czeslavo added this to the KIC v3.2.x milestone Jun 7, 2024
@czeslavo czeslavo force-pushed the fix/fallback-backfill branch from 4d5f545 to 475cd8c Compare June 7, 2024 18:13
@czeslavo czeslavo marked this pull request as ready for review June 7, 2024 18:15
@czeslavo czeslavo requested a review from a team as a code owner June 7, 2024 18:15
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.5%. Comparing base (d62262e) to head (475cd8c).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/dataplane/fallback/fallback.go 65.2% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6172     +/-   ##
=======================================
+ Coverage   73.7%   74.5%   +0.8%     
=======================================
  Files        198     198             
  Lines      19742   19760     +18     
=======================================
+ Hits       14560   14739    +179     
+ Misses      4202    4025    -177     
- Partials     980     996     +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo assigned programmer04 and unassigned programmer04 Jun 7, 2024
@czeslavo czeslavo requested a review from programmer04 June 7, 2024 18:16
Copy link
Member

@programmer04 programmer04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@czeslavo czeslavo merged commit 0b7e192 into main Jun 10, 2024
41 checks passed
@czeslavo czeslavo deleted the fix/fallback-backfill branch June 10, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants