-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement KongLicense controller and inject to translator #5514
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5514 +/- ##
=======================================
- Coverage 71.8% 71.2% -0.6%
=======================================
Files 176 177 +1
Lines 18085 18301 +216
=======================================
+ Hits 12986 13042 +56
- Misses 4157 4306 +149
- Partials 942 953 +11 ☔ View full report in Codecov by Sentry. |
def8fad
to
602546f
Compare
602546f
to
ee4f248
Compare
c37ef6c
to
2c2138a
Compare
BTW it might make sense to not include integration tests and translator code in this PR to not make it bigger as it's already 2k+ lines. :) |
Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/7795253842 |
What this PR does / why we need it:
The PR implements a
KongLicense
controller which picks the newestKongLicense
in the cluster and provides aGetLicense
method for translator to inject Kong license into Kong configurations.The controller is enabled when
--enable-controller-kong-license
is set totrue
(by default) and sync license with Konnect disabled. When sync license with Konnect is enabled, the licenses from Konnect takes the precedence.Which issue this PR fixes:
Major part of #5437.
Special notes for your reviewer:
Not fully finished yet, but can reconcile
KongLicense
resources and ready to receive some reviews. Major remaining part:KongLicense
CRD in cluster, the controller will exit abnormallyKongLicense
?PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR