-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Programmed condition to KongUpstreamPolicy ancestors status #5444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
feat/programmed-upstream-policy
branch
2 times, most recently
from
January 15, 2024 19:55
abad5bb
to
f2fad06
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5444 +/- ##
=======================================
+ Coverage 69.8% 71.5% +1.7%
=======================================
Files 176 176
Lines 22626 22723 +97
=======================================
+ Hits 15795 16255 +460
+ Misses 5904 5513 -391
- Partials 927 955 +28 ☔ View full report in Codecov by Sentry. |
czeslavo
force-pushed
the
feat/programmed-upstream-policy
branch
from
January 16, 2024 10:55
f2fad06
to
13d8087
Compare
czeslavo
force-pushed
the
feat/programmed-upstream-policy
branch
from
January 16, 2024 10:57
13d8087
to
96cbf05
Compare
1 task
czeslavo
force-pushed
the
feat/programmed-upstream-policy
branch
4 times, most recently
from
January 18, 2024 09:25
756d405
to
08c372b
Compare
1 task
czeslavo
force-pushed
the
feat/programmed-upstream-policy
branch
from
January 18, 2024 13:32
08c372b
to
1c51035
Compare
randmonkey
approved these changes
Jan 19, 2024
tao12345666333
approved these changes
Jan 19, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
Programmed
condition toKongUpstreamPolicy
ancestors status forService
andKongServiceFacade
based on their configuration status in the data plane.Which issue this PR fixes:
Closes #5249.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR