fix: do not set instance_name of plugin if Kong version is below 3.2.0
#5250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2.12.x #5250 +/- ##
================================================
Coverage ? 68.0%
================================================
Files ? 165
Lines ? 19343
Branches ? 0
================================================
Hits ? 13160
Misses ? 5397
Partials ? 786 ☔ View full report in Codecov by Sentry. |
czeslavo
reviewed
Nov 29, 2023
mlavacca
reviewed
Nov 29, 2023
f85aa74 to
c46d93e
Compare
czeslavo
approved these changes
Nov 29, 2023
mlavacca
approved these changes
Nov 29, 2023
This was referenced Nov 30, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Kong added
instance_namefield first in 3.2.0: https://docs.konghq.com/gateway/3.2.x/admin-api/#plugin-object. If Kong version is below 3.2.0, we should not setinstance_namefield to prevent "unknown field" error.Which issue this PR fixes:
Fixes #5241
Special notes for your reviewer:
Addedreverted the change after update.KongVersioninKongStatestructure. This requires settingKongVersionevery where whenKongStateis used because this field cannot be left empty. Please check if there are any missing places.PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PRREVIEW: I did not see CHANGELOG of 2.12.1/2.12.2 in the
release/2.12.xbranch. When do we update the changelog?