-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(logs): The log format starts with a capital letter in internal/dataplane #5065
Conversation
eb65880
to
9ac8a84
Compare
This will be the last PR for this part of the modification. (it will close #3708) |
Sorry, I missed a modification. It has been updated. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5065 +/- ##
=======================================
+ Coverage 73.3% 75.6% +2.2%
=======================================
Files 167 167
Lines 18909 18909
=======================================
+ Hits 13867 14297 +430
+ Misses 4218 3788 -430
Partials 824 824
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubernetes-ingress-controller/test/integration/translation_failures_test.go
should be updated to match the modified translation failure reasons.
13da440
to
5687410
Compare
What this PR does / why we need it:
Which issue this PR fixes:
fixes: #3708
Special notes for your reviewer:
This PR more about
internal/dataplane
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR