use namespace kong for integration tests #4439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4439 +/- ##
=======================================
- Coverage 67.9% 67.8% -0.2%
=======================================
Files 161 161
Lines 18817 18817
=======================================
- Hits 12788 12764 -24
- Misses 5270 5296 +26
+ Partials 759 757 -2 ☔ View full report in Codecov by Sentry. |
59db41d to
59eb210
Compare
|
blocked by Kong/kubernetes-testing-framework#765 |
59eb210 to
020b873
Compare
020b873 to
17a7ad2
Compare
17a7ad2 to
048dd9c
Compare
|
Integration (targeted) tests with KIND-based cluster and latest images were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5806095248 |
czeslavo
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
use namespace
konginstead ofkong-systemfor integration tests, and change the hard coded namespacekong-systemtoconst.ControllerNamespace.Which issue this PR fixes:
fixes #4431
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR