-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parser) support same-name services across NSes #4375
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4375 +/- ##
=====================================
Coverage 66.6% 66.7%
=====================================
Files 158 158
Lines 18563 18571 +8
=====================================
+ Hits 12379 12396 +17
+ Misses 5429 5426 -3
+ Partials 755 749 -6
☔ View full report in Codecov by Sentry. |
a3c2cfd
to
e571956
Compare
Correctly build upstreams for multiple backends where multiple services in the backends share the same name in different namespaces. Previously services were indexed by name alone in the rule builder, resulting in one clobbering the other(s).
e571956
to
8ed3d77
Compare
8ed3d77
to
1a217fa
Compare
This encountered a flake with TestGatewayWithGatewayClassReconciliation in envtests. Could not replicate, and don't think we have an equivalent of the integration dumps to try and analyze why it happens when it does. |
What this PR does / why we need it:
Correctly build upstreams for multiple backends where multiple services in the backends share the same name in different namespaces. Previously services were indexed by name alone in the rule builder, resulting in one clobbering the other(s).
Which issue this PR fixes:
Fix #3860
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR