Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fetch and store last good config #4265

Merged
merged 9 commits into from
Jul 21, 2023
Merged

feat: fetch and store last good config #4265

merged 9 commits into from
Jul 21, 2023

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Jul 3, 2023 •
edited
Loading

What this PR does / why we need it:

Which issue this PR fixes:

Fixes #4264

Special notes for your reviewer:

E2E test run: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5541688927/jobs/10115626302

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@mlavacca mlavacca force-pushed the mlavacca/fetch-last-good-config branch from 9809769 to 61802eb Compare July 3, 2023 09:43
@codecov
Copy link

codecov bot commented Jul 3, 2023 •
edited
Loading

Codecov Report

Patch coverage: 94.0% and project coverage change: +0.3 🎉

Comparison is base (d99ec37) 65.5% compared to head (d1679fd) 65.8%.

❗ Current head d1679fd differs from pull request most recent head 2d5f0b7. Consider uploading reports for the commit 2d5f0b7 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #4265     +/-   ##
=======================================
+ Coverage   65.5%   65.8%   +0.3%     
=======================================
  Files        154     157      +3     
  Lines      17740   18156    +416     
=======================================
+ Hits       11623   11952    +329     
- Misses      5385    5467     +82     
- Partials     732     737      +5
Impacted Files Coverage Δ
internal/dataplane/kongstate/types.go 95.0% <ø> (ø)
internal/dataplane/kongstate/upstream.go 63.5% <ø> (ø)
internal/dataplane/kong_client.go 84.2% <70.5%> (-0.9%) ⬇️
internal/dataplane/configfetcher/config_fetcher.go 84.6% <84.6%> (ø)
internal/dataplane/configfetcher/kongrawstate.go 97.0% <97.0%> (ø)
...nal/dataplane/sendconfig/config_change_detector.go 100.0% <100.0%> (ø)
internal/dataplane/synchronizer.go 93.5% <100.0%> (ø)
internal/manager/config_validation.go 83.1% <100.0%> (ø)
internal/manager/run.go 53.0% <100.0%> (+0.1%) ⬆️
internal/manager/setup.go 67.6% <100.0%> (ø)
... and 1 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mlavacca mlavacca force-pushed the mlavacca/fetch-last-good-config branch 11 times, most recently from 042e409 to d44c118 Compare July 5, 2023 15:54
@mlavacca mlavacca force-pushed the mlavacca/fetch-last-good-config branch 8 times, most recently from e08726e to a8f3484 Compare July 13, 2023 10:09
@mlavacca mlavacca marked this pull request as ready for review July 13, 2023 10:14
@mlavacca mlavacca requested a review from a team as a code owner July 13, 2023 10:14
czeslavo
czeslavo reviewed Jul 13, 2023
View reviewed changes
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
internal/dataplane/kong_client_test.go Show resolved Hide resolved
internal/dataplane/kongstate/types.go Outdated Show resolved Hide resolved
internal/dataplane/sendconfig/config_getter.go Outdated Show resolved Hide resolved
internal/dataplane/sendconfig/config_getter.go Outdated Show resolved Hide resolved
programmer04
programmer04 reviewed Jul 13, 2023
View reviewed changes
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
test/e2e/all_in_one_test.go Outdated Show resolved Hide resolved
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
mlavacca added 2 commits July 19, 2023 12:40
@mlavacca
test(unit): fetch, store and push config
3450547 
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca
chore: improve kongRawState to kongState
6612656 
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca force-pushed the mlavacca/fetch-last-good-config branch 2 times, most recently from ab1d46e to 18c61ee Compare July 19, 2023 10:53
mlavacca added 2 commits July 19, 2023 13:00
@mlavacca
feat: all supported kongRawState fields translated
f25e52c 
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca
chore: isDBLess helper introduced
3bddbf2 
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca force-pushed the mlavacca/fetch-last-good-config branch from 18c61ee to 3bddbf2 Compare July 19, 2023 11:00
@mlavacca mlavacca added the ci/run-e2e Trigger e2e test run from PR label Jul 19, 2023
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5598316236

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Jul 19, 2023
@mlavacca mlavacca force-pushed the mlavacca/fetch-last-good-config branch from bf646c3 to ba25db2 Compare July 19, 2023 13:22
@mlavacca mlavacca added the ci/run-e2e Trigger e2e test run from PR label Jul 19, 2023
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5599724259

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Jul 19, 2023
@mlavacca mlavacca requested review from mheap, programmer04, czeslavo and randmonkey and removed request for mheap July 19, 2023 13:36
@mlavacca
chore: configfetcher interface added
9bb240b 
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca force-pushed the mlavacca/fetch-last-good-config branch from ba25db2 to 9bb240b Compare July 19, 2023 15:04
@mlavacca mlavacca requested a review from czeslavo July 19, 2023 15:05
@mlavacca
chore: fillIDs introduced in config fetcher
2d5f0b7 
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
czeslavo
czeslavo approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mlavacca mlavacca enabled auto-merge (squash) July 21, 2023 09:46
@mlavacca mlavacca merged commit 167765f into main Jul 21, 2023
@mlavacca mlavacca deleted the mlavacca/fetch-last-good-config branch July 21, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mheap mheap mheap left review comments

@czeslavo czeslavo czeslavo approved these changes

@programmer04 programmer04 Awaiting requested review from programmer04

@randmonkey randmonkey Awaiting requested review from randmonkey

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch and store current valid configuration from Proxy
6 participants
@mlavacca @team-k8s-bot @mheap @czeslavo @programmer04 @randmonkey