tests: align E2E to dynamic handling of GW API CRDs #4021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E (targeted) tests were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5001308234 |
pmalek
approved these changes
May 17, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4021 +/- ##
=======================================
- Coverage 59.6% 59.5% -0.1%
=======================================
Files 149 149
Lines 16406 16406
=======================================
- Hits 9783 9776 -7
- Misses 5987 5992 +5
- Partials 636 638 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Missing
GatewayandHTTPRoutewill no longer output the log that was expected in theTestMissingCRDsDontCrashTheControlleras they are using now theDynamicCRDControllerthat was introduced in #3996.