Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): make all all-in-one dbless manifests use multi-gw #3629

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Feb 28, 2023

What this PR does / why we need it:

  • Makes all all-in-one DB-less manifests use multi-gw config.
  • Renames old single-Deployment all-in-one-dbless.yaml to all-in-one-dbless-legacy.yaml.
  • Uses a projected volume instead of a static SA secret in the multi-gw proxy deployment.
  • Aligns all the affected E2E tests to work with multi-gw config as expected.

E2E tests run: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/4308118461

Which issue this PR fixes:

Closes #3423.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.3 🎉

Comparison is base (bc86d7b) 72.6% compared to head (37104a4) 72.9%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3629     +/-   ##
=======================================
+ Coverage   72.6%   72.9%   +0.3%     
=======================================
  Files        131     131             
  Lines      15723   15723             
=======================================
+ Hits       11423   11474     +51     
+ Misses      3546    3489     -57     
- Partials     754     760      +6     
Impacted Files Coverage Δ
...nternal/controllers/gateway/tlsroute_controller.go 71.4% <0.0%> (-2.1%) ⬇️
internal/konnect/client.go 42.1% <0.0%> (ø)
...nternal/controllers/gateway/udproute_controller.go 73.7% <0.0%> (+2.1%) ⬆️
...ntrollers/configuration/kongadminapi_controller.go 62.9% <0.0%> (+62.9%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pull-request-size pull-request-size bot added size/XL and removed size/L labels Mar 1, 2023
@czeslavo czeslavo force-pushed the make-gd-a-default branch from 096e3cd to 1c9cfb6 Compare March 1, 2023 15:39
@czeslavo czeslavo force-pushed the make-gd-a-default branch 11 times, most recently from ea479ca to 2861273 Compare March 1, 2023 21:28
@czeslavo czeslavo changed the title feat(config): deprecate dbless single-pod all-in-one manifest feat(config): make all all-in-one dbless manifests use multi-gw Mar 1, 2023
@czeslavo czeslavo force-pushed the make-gd-a-default branch from 2861273 to 37104a4 Compare March 1, 2023 21:59
@czeslavo czeslavo self-assigned this Mar 1, 2023
@czeslavo czeslavo added area/feature New feature or request area/tests labels Mar 1, 2023
@czeslavo czeslavo added this to the KIC v2.9.0 milestone Mar 1, 2023
@czeslavo czeslavo marked this pull request as ready for review March 1, 2023 22:05
@czeslavo czeslavo requested a review from a team as a code owner March 1, 2023 22:05
@rainest rainest merged commit b6c1363 into main Mar 1, 2023
@rainest rainest deleted the make-gd-a-default branch March 1, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all-in-one-dbless use SCD
2 participants