-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make scheme conditional on provided feature gates #3539
Conversation
1218fd1
to
ea50b60
Compare
ea50b60
to
9ccdd54
Compare
Codecov ReportBase: 72.2% // Head: 72.4% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3539 +/- ##
=======================================
+ Coverage 72.2% 72.4% +0.2%
=======================================
Files 122 123 +1
Lines 14381 14384 +3
=======================================
+ Hits 10395 10428 +33
+ Misses 3314 3292 -22
+ Partials 672 664 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Could you elaborate on this a little bit? Is this exploratory work related to using |
Something like this: #2250 but I managed to figure out a patch that incurs way less changes. This way, if we pursue this route for all object's |
What this PR does / why we need it:
This PR makes the manager scheme to be conditional on the provided feature gates.
Apart from e.g. not registering schemes that we don't use this might come in handy later ;). For instance: doing some exploratory work for using
client.Client
inStore
I noticed that this will be useful to have.PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR