-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Konnect client & move tls cert extract to util #3469
Conversation
Codecov ReportBase: 73.8% // Head: 72.8% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3469 +/- ##
=======================================
- Coverage 73.8% 72.8% -1.1%
=======================================
Files 116 119 +3
Lines 13883 14099 +216
=======================================
+ Hits 10258 10272 +14
- Misses 2962 3167 +205
+ Partials 663 660 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
d5b6e16
to
e64e268
Compare
9a57bc4
to
4b02244
Compare
9cc6489
to
0dfc564
Compare
IMO from the functional perspective this PR might be already merged. We'd just need to create tracking issues for all the TODOs left here and there (handling the task shutdown, parsing error response, etc.). |
0dfc564
to
40fe004
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also feel that we can merge this but I'd prefer to remove all those TODOs with references to issues created in this repo.
put the followups into 2 issues:
|
d6afa98
to
f1e911d
Compare
What this PR does / why we need it:
Which issue this PR fixes:
expected to fix #3438
Special notes for your reviewer:
This PR will only include updating nodes for KIC itself to Konnect to avoid it being too large. works for uploading status of managed kong gateway nodes are tracked in issue #3501.
Includes extracting code for getting TLS cert into
internal/util/tls
package. If this change is useful, I'll consider move the change to a separate PR.PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR