-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for plugin ordering #2657
Conversation
86d6e22
to
e7da908
Compare
e7da908
to
e479601
Compare
a1ed9ee
to
7549b03
Compare
7549b03
to
e6c3763
Compare
f02db8c
to
fc3a0d1
Compare
fc3a0d1
to
ed9e6f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid to me, even though it says draft. I would just like to see us use the new cleanup method for the integration tests and then LGTM.
ed9e6f9
to
0ed231f
Compare
0ed231f
to
a538c4c
Compare
Kong nightly failure on the TLSRoute example is on the Kong side. It cannot find the workspace ID of the certificate. The upstream bug that corrects this is fixed, but at some point the Kong nightly repo stopped updating
Don't think the resource matters since DB-less should always be the default WS, but whatever:
|
Add a new ordering field to KongPlugin and KongClusterPlugin. On Enterprise instances, this can manipulate plugin execution order. Add integration test runs for nightly Kong images.
e2089e5
to
8872119
Compare
? New PR coming? |
What this PR does / why we need it:
Adds plugin ordering support. Uses unreleased KTF, deck, and go-kong for now. Adds integration tests against nightly Kong images. Requesting review in advance of dependencies since I want to avoid multiple upstream releases in case change requests affect stuff in libraries.
Depends on Kong/go-kong#187, Kong/deck#710, and Kong/kubernetes-testing-framework#314
Fix #2656
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR