Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add HTTPRouteCrossNamespace Gateway conformance test #2339

Merged
merged 6 commits into from
Mar 18, 2022
Merged

tests: add HTTPRouteCrossNamespace Gateway conformance test #2339

merged 6 commits into from
Mar 18, 2022

Conversation

shaneutt
Copy link
Contributor

@shaneutt shaneutt commented Mar 17, 2022 •
edited
Loading

What this PR does / why we need it:

This enables the HTTPRouteCrossNamespace conformance test from upstream Gateway API.

Special notes for your reviewer:

This PR also fixes some issues that were relevant to adding that test:

  • fix: remove duplicate addrs on unmanaged gateways (a random bug I noticed)
  • fix: prepend LB addrs in unmanaged GWs (fixes Gateway - short view shows clusterip for address when LB ip is available #2050, I was already working in that code and it was easy)
  • fix: use ConditionRouteAccepted for HTTPRoute accept (specifically for HTTPRoute conformance)
  • fix: wait for dataplane before reporting httproute accepted status (specifically for HTTPRoute conformance)

Which issue this PR fixes

Partially resolves #2210

Fully resolves #2050

PR Readiness Checklist:

  • the CHANGELOG.md release notes have been updated

@shaneutt shaneutt added this to the Gateway API - Milestone 2 milestone Mar 17, 2022
@shaneutt shaneutt self-assigned this Mar 17, 2022
@shaneutt shaneutt temporarily deployed to Configure ci March 17, 2022 21:25 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci March 17, 2022 21:25 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci March 17, 2022 21:31 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci March 17, 2022 21:31 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci March 17, 2022 21:46 Inactive
@shaneutt shaneutt marked this pull request as ready for review March 17, 2022 21:47
@shaneutt shaneutt requested a review from a team as a code owner March 17, 2022 21:47
@shaneutt shaneutt enabled auto-merge (rebase) March 17, 2022 21:47
mflendrich
mflendrich reviewed Mar 18, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
test/conformance/gateway_conformance_test.go Outdated Show resolved Hide resolved
test/conformance/gateway_conformance_test.go Outdated Show resolved Hide resolved
@shaneutt shaneutt temporarily deployed to Configure ci March 18, 2022 16:09 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci March 18, 2022 16:09 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci March 18, 2022 16:09 Inactive
@shaneutt shaneutt force-pushed the shaneutt/gateway-conformance-tests-httproute branch from 5129062 to b6bf34d Compare March 18, 2022 16:13
@shaneutt shaneutt temporarily deployed to Configure ci March 18, 2022 16:13 Inactive
@shaneutt shaneutt requested a review from mflendrich March 18, 2022 16:13
@shaneutt shaneutt temporarily deployed to Configure ci March 18, 2022 16:14 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci March 18, 2022 16:30 Inactive
@shaneutt shaneutt disabled auto-merge March 18, 2022 16:48
@shaneutt shaneutt merged commit 9f8bdd5 into main Mar 18, 2022
@shaneutt shaneutt deleted the shaneutt/gateway-conformance-tests-httproute branch March 18, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mflendrich mflendrich mflendrich approved these changes

Assignees

@shaneutt shaneutt

Labels
area/tests ci/license/unchanged priority/medium
Projects
None yet
Milestone
Gateway API - Milestone 2
Development

Successfully merging this pull request may close these issues.

L7 Gateway API Conformance Gateway - short view shows clusterip for address when LB ip is available
2 participants
@shaneutt @mflendrich