-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unnecessary GOARCH env in Dockerfile #1046
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1046 +/- ##
=======================================
Coverage 49.42% 49.42%
=======================================
Files 32 32
Lines 3207 3207
=======================================
Hits 1585 1585
Misses 1492 1492
Partials 130 130 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! 🥳
The upstream image already supports a variety of platforms, so I can appreciate and understand wanting to remove this declaration to make it easier to build for other platforms, so from a purely functional perspective this LGTM.
However please do note that amd64 is the only platform we support at the moment and we're not yet ready to support other platforms due to testing and other logistics.
If you're interested in getting support for ARM I would recommend subscribing to #1019 and contributing there with context about your use case(s) to help drive that forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To confirm, @shaneutt your comment is effectively "we'll remove the restriction, but be aware that we don't actually support anything else and you're on your own if it breaks"?
I think that's the case, and don't see a reason we need to keep this, since we build images on amd64 machines and Go will default to that.
That's right. |
What this PR does / why we need it:
When I build kic in arm64 environment, I found GOARCH hard coded in Dockerfile.