Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admission webhook for validating KongPlugin resources #245

Closed
hbagdi opened this issue Mar 8, 2019 · 0 comments · Fixed by #372
Closed

Admission webhook for validating KongPlugin resources #245

hbagdi opened this issue Mar 8, 2019 · 0 comments · Fixed by #372
Labels
area/feature New feature or request
Milestone

Comments

@hbagdi
Copy link
Member

hbagdi commented Mar 8, 2019

KongPlugin resource allows for specifying an arbitrary config.

A lot of users run into problems where the config is not valid, sometimes arrays are represents as maps, sometimes validation of a value fails, typos, etc.

This problem can be solved by introducing an Admission webhook controller, which takes in a KongPlugin object and validates the configuration against the corresponding Kong plugin's schema.

This catches most of the errors that users run into currently while using the Ingress controller.

@hbagdi hbagdi added this to the 0.6.0 milestone Jun 7, 2019
@hbagdi hbagdi added the area/feature New feature or request label Aug 12, 2019
hbagdi added a commit that referenced this issue Sep 4, 2019
Users frequently stumble onto situation where a mis-configured plugin
stops the entire controller from functioning.

It is now possible to setup an admission validation Webhook to prevent
users from mis-configuring plugins and consumers.

Documentation on how to configure the controller will be published soon
and this controller will include KongCredentials in the future.

Fix #245 
From #372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
1 participant