fix(controller): Do not update existing Programmed condition to Unkno…

…wn (#6395) (#6402)

* Do not update existing Programmed condition to Unknown

* do not fetch before update

(cherry picked from commit 4b0a44a)

Co-authored-by: Tao Yi <tao.yi@konghq.com>

hack/generators/controllers/networking/main.go

@@ -725,8 +725,8 @@ func (r *{{.PackageAlias}}{{.Kind}}Reconciler) Reconcile(ctx context.Context, re
 		{{- end }}
 
 		{{- if .ProgrammedCondition.UpdatesEnabled }}
-		log.V(logging.DebugLevel).Info("Updating programmed condition status", "namespace", req.Namespace, "name", req.Name)
 		configurationStatus := r.DataplaneClient.KubernetesObjectConfigurationStatus(obj)
+		log.V(logging.DebugLevel).Info("Updating programmed condition status", "namespace", req.Namespace, "name", req.Name, "configuration_status",configurationStatus)
 		conditions, updateNeeded := ctrlutils.EnsureProgrammedCondition(
 			configurationStatus, 
 			obj.Generation, 

internal/controllers/utils/conditions.go

@@ -94,6 +94,10 @@ func EnsureProgrammedCondition(
 	if !ok {
 		conditions = append(conditions, desiredCondition)
 	} else {
+		// Do not update existing "Programmed" condition to Unknown to prevent races on updating status when new instance starts.
+		if configurationStatus == object.ConfigurationStatusUnknown {
+			return conditions, false
+		}
 		conditions[idx] = desiredCondition
 	}
 

internal/controllers/utils/conditions_test.go

@@ -84,17 +84,24 @@ func TestEnsureProgrammedCondition(t *testing.T) {
 		},
 		{
 			name:                "condition present with correct observed generation but different reason",
-			configurationStatus: object.ConfigurationStatusUnknown,
+			configurationStatus: object.ConfigurationStatusFailed,
 			conditions: []metav1.Condition{
 				func() metav1.Condition {
-					cond := expectedProgrammedConditionUnknown
-					cond.Reason = string(kongv1.ReasonInvalid)
+					cond := expectedProgrammedConditionFalse
+					cond.Reason = string("SomeOtherReason")
 					return cond
 				}(),
 			},
-			expectedUpdatedConditions: []metav1.Condition{expectedProgrammedConditionUnknown},
+			expectedUpdatedConditions: []metav1.Condition{expectedProgrammedConditionFalse},
 			expectedUpdateNeeded:      true,
 		},
+		{
+			name:                      "Unknown status should not modify existing Programmed condition",
+			configurationStatus:       object.ConfigurationStatusUnknown,
+			conditions:                []metav1.Condition{expectedProgrammedConditionTrue},
+			expectedUpdatedConditions: []metav1.Condition{expectedProgrammedConditionTrue},
+			expectedUpdateNeeded:      false,
+		},
 		{
 			name:                      "empty conditions",
 			configurationStatus:       object.ConfigurationStatusSucceeded,