Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kinputswitch): add tooltipattributes prop #2613

Merged
merged 2 commits into from
Feb 12, 2025
Merged

fix(kinputswitch): add tooltipattributes prop #2613

merged 2 commits into from
Feb 12, 2025

Conversation

portikM
Copy link
Member

@portikM portikM commented Feb 12, 2025 •
edited
Loading

Summary

Add tooltipAttributes prop in KInputSwitch to give a way to control tooltip placement when disabledTooltipText prop is used

Before
Screenshot 2025-02-12 at 11 11 53 AM

After
Screenshot 2025-02-12 at 11 28 40 AM

@portikM portikM self-assigned this Feb 12, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 12, 2025 •
edited
Loading

✅ Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 22b6ddd
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/67acd87e14435c00087dd03b
😎 Deploy Preview https://deploy-preview-2613--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Feb 12, 2025 •
edited
Loading

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 22b6ddd
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/67acd87e6225960008d61f7e
😎 Deploy Preview https://deploy-preview-2613--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM marked this pull request as ready for review February 12, 2025 16:35
kaiarrowood
kaiarrowood previously approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior looks good 🚀

@portikM portikM enabled auto-merge (squash) February 12, 2025 17:24
@portikM portikM requested a review from kaiarrowood February 12, 2025 17:47
kaiarrowood
kaiarrowood approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@portikM portikM merged commit 89c8ff9 into main Feb 12, 2025
10 checks passed
@portikM portikM deleted the fix/kinputswitch-tooltip-attributes-prop branch February 12, 2025 19:28
kongponents-bot pushed a commit that referenced this pull request Feb 12, 2025
@semantic-release-bot
chore(release): 9.21.2 [skip ci]
e7332c6 
## [9.21.2](v9.21.1...v9.21.2) (2025-02-12)

### Bug Fixes

* **kinputswitch:** add tooltipattributes prop ([#2613](#2613)) ([89c8ff9](89c8ff9))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.21.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiarrowood kaiarrowood kaiarrowood approved these changes

@adamdehaven adamdehaven Awaiting requested review from adamdehaven adamdehaven is a code owner

@jillztom jillztom Awaiting requested review from jillztom jillztom is a code owner

@Justineo Justineo Awaiting requested review from Justineo Justineo is a code owner

Assignees

@portikM portikM

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portikM @kongponents-bot @kaiarrowood