Skip to content

Commit

Permalink
chore(node): use node 14 (#458)
Browse files Browse the repository at this point in the history
* chore(node): use node 14

Use node 14 instead of node 12.

* fix(nvmrc): update nvmrc

Update version in nvmrc.

* chore(actions): reference nvmrc in actions

Utilize nvmrc node version value.

* chore(actions): fix node variable

Fix node variable in actions.

* chore(action): fix

Fix the action.
  • Loading branch information
adamdehaven authored Dec 17, 2021
1 parent c9a3a3c commit cd80946
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 15 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ on:
jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
node: [12.x]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node }}
uses: actions/setup-node@v1
- name: Read .nvmrc
run: echo ::set-output name=NVMRC::$(cat .nvmrc)
id: nvm
- name: Use Node.js
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node }}
node-version: '${{ steps.nvm.outputs.NVMRC }}'
- name: install and lint
run: |
yarn
Expand All @@ -42,9 +42,9 @@ jobs:
- uses: actions/checkout@v2
with:
token: ${{ secrets.KONGPONENTS_BOT_PAT }}
- uses: actions/setup-node@v1
- uses: actions/setup-node@v2
with:
node-version: 12.x
node-version: '${{ steps.nvm.outputs.NVMRC }}'

- name: setup git
run: |
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,15 @@ jobs:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node: [12.x]
steps:
- uses: actions/checkout@v1
- name: Use Node.js ${{ matrix.node }}
uses: actions/setup-node@v1
- name: Read .nvmrc
run: echo ::set-output name=NVMRC::$(cat .nvmrc)
id: nvm
- name: Use Node.js
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node }}
node-version: '${{ steps.nvm.outputs.NVMRC }}'
- name: install, lint
run: |
yarn install
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
12.22.5
14.18.2
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
"vue-uuid": "^2.0.2"
},
"engines": {
"node": ">=12.20 <14"
"node": ">=14.8.2 <15"
},
"jest": {
"moduleFileExtensions": [
Expand Down

0 comments on commit cd80946

Please sign in to comment.