fix(core): set correct permissions for socket path when umask is set to 0027
#14084
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to `0027` When umask is configured to `0027`, the newly created `kong_config.socket_path` directory inherits permissions `750`, which restricts access for worker processes. This commit ensures that the `socket_path` directory is explicitly set to permissions `755` using `chmod 755`, thereby preventing permission-related errors and allowing proper access for all necessary processes. Fix: [FTI-6298](https://konghq.atlassian.net/browse/FTI-6298) Signed-off-by: tzssangglass <tzssangglass@gmail.com>
ms2008
reviewed
Jan 7, 2025
Comment on lines
+513
to
+514
| local success = pl_utils.executeex("chmod 755 " .. kong_config.socket_path) | ||
| if not success then |
There was a problem hiding this comment.
Suggested change
| local success = pl_utils.executeex("chmod 755 " .. kong_config.socket_path) | |
| if not success then | |
| ok = pl_utils.executeex("chmod 755 " .. kong_config.socket_path) | |
| if not ok then |
Also executeex returns stderr, should we handle it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When umask is configured to
0027, the newly createdkong_config.socket_pathdirectory inherits permissions750, which restricts access for worker processes. This commit ensures that thesocket_pathdirectory is explicitly set to permissions755usingchmod 755, thereby preventing permission-related errors and allowing proper access for all necessary processes.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix: FTI-6298