Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clustering/rpc): change sync version to string #14078

Merged
merged 19 commits into from
Jan 12, 2025
Merged

feat(clustering/rpc): change sync version to string #14078

merged 19 commits into from
Jan 12, 2025

Conversation

chronolaw
Copy link
Contributor

Summary

KAG-5894

Checklist

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/clustering core/db cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jan 3, 2025
@chronolaw chronolaw marked this pull request as ready for review January 3, 2025 04:36
@chronolaw chronolaw marked this pull request as draft January 3, 2025 10:21
@chronolaw chronolaw marked this pull request as ready for review January 6, 2025 02:50
StarlightIbuki
StarlightIbuki approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@StarlightIbuki StarlightIbuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MInor issues. Not blockers

kong/clustering/services/sync/rpc.lua Outdated Show resolved Hide resolved
kong/clustering/services/sync/rpc.lua Show resolved Hide resolved
dndx
dndx requested changes Jan 6, 2025
View reviewed changes
kong/clustering/services/sync/rpc.lua Outdated Show resolved Hide resolved
dndx
dndx requested changes Jan 8, 2025
View reviewed changes
kong/clustering/services/sync/rpc.lua Outdated Show resolved Hide resolved
@dndx dndx merged commit 4ee00b3 into master Jan 12, 2025
26 checks passed
@dndx dndx deleted the feat/sync_version_string branch January 12, 2025 03:47
@chronolaw chronolaw mentioned this pull request Jan 13, 2025
Merged
3 tasks
ADD-SP pushed a commit that referenced this pull request Jan 14, 2025
@chronolaw
refactor(clustering/rpc): move is_valid_version() to strategies (#14135)
4d56a90 
code clean of #14078

KAG-5894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Water-Melon Water-Melon Water-Melon left review comments

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

@dndx dndx dndx approved these changes

@chobits chobits chobits approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering core/db size/M skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chronolaw @chobits @dndx @Water-Melon @StarlightIbuki