Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): rename rust target wasm32-wasi to wasm32-wasip1 #13708

Merged
merged 3 commits into from
Jan 10, 2025
Merged

chore(build): rename rust target wasm32-wasi to wasm32-wasip1 #13708

merged 3 commits into from
Jan 10, 2025

Conversation

flrgh
Copy link
Contributor

@flrgh flrgh commented Sep 24, 2024 •
edited
Loading

See https://blog.rust-lang.org/2024/04/09/updates-to-rusts-wasi-targets.html and rust-lang/rust#126662

Note: this only affects filters built/used for integration tests.

@github-actions github-actions bot added chore Not part of the core functionality of kong, but still needed build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Sep 24, 2024
@flrgh flrgh force-pushed the chore/wasm-filter-target-rename branch from 0b1fef1 to 3f4ebf4 Compare September 24, 2024 17:31
@flrgh flrgh changed the title WIP: rename wasm32-wasi => wasm32-wasip1 chore(build): rename rust target wasm32-wasi to wasm32-wasip1 Sep 24, 2024
@flrgh flrgh marked this pull request as ready for review September 24, 2024 17:40
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 24, 2024
@flrgh flrgh requested review from brentos and locao September 25, 2024 15:05
@flrgh flrgh removed the author/community PRs from the open-source community (not Kong Inc) label Sep 25, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 25, 2024
@flrgh flrgh force-pushed the chore/wasm-filter-target-rename branch from 3f4ebf4 to 727ea86 Compare October 22, 2024 22:43
@brentos
Copy link
Contributor

brentos commented Oct 23, 2024

@flrgh it looks like this is failing for the build & test step. Does the new wasm32-wasip1 target move the files to a different directory? Maybe target/wasm32-wasip1?

@flrgh
Copy link
Contributor Author

flrgh commented Oct 23, 2024

@flrgh it looks like this is failing for the build & test step. Does the new wasm32-wasip1 target move the files to a different directory? Maybe target/wasm32-wasip1?

I think this was due to a cached build that used the old target name. a3766ed adds the target to the cache key

@team-eng-enablement team-eng-enablement removed the author/community PRs from the open-source community (not Kong Inc) label Nov 4, 2024
@flrgh flrgh force-pushed the chore/wasm-filter-target-rename branch from a3b3f58 to cead534 Compare January 8, 2025 17:50
@tzssangglass
Copy link
Member

Would this PR be backported? Many versions have this problem.

@curiositycasualty curiositycasualty merged commit 1903d97 into master Jan 10, 2025
24 checks passed
@curiositycasualty curiositycasualty deleted the chore/wasm-filter-target-rename branch January 10, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzssangglass tzssangglass tzssangglass approved these changes

@brentos brentos brentos approved these changes

@locao locao Awaiting requested review from locao

Assignees

@flrgh flrgh

Labels
build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@flrgh @brentos @tzssangglass @curiositycasualty @team-eng-enablement @team-gateway-bot