Ubuntu 24 runner support #8326
Ubuntu 24 runner support #8326
Conversation
hexchain
commented
Jan 28, 2025
•
- Update Linux runner OS to Ubuntu 24.04 again
- Ensure unprivileged user namespace is available to normal user
- Applied some workarounds for ARM64 Linux runner issues
|
Hmmm, strange... the exact same job works without problem in my fork: https://github.com/hexchain/insomnia/actions/runs/13013477749/job/36296739340 |
|
I see, the failing one is a different workflow. Fixed. |
bf8dc2d to
1c32476
Compare
This reverts commit cc0cdb6.
|
I've rebased this against |
| if: runner.os == 'Linux' | ||
| run: | | ||
| # install snapcraft | ||
| sudo snap install snapcraft --classic | ||
|
|
||
| # install fpm for electron-builder | ||
| sudo gem install fpm | ||
| fpm --version |
There was a problem hiding this comment.
Can this be arm only? I think x64 already works, or was snap removed in Ubuntu 24?
There was a problem hiding this comment.
Looks like we are using two workarounds here
- lift ubuntu 24 restrictions
- electron-builder doesn't bundle a arm64 fpm
Both of these appear to be open issues, which will hopefully be solved in time.
What motivation do we have to add these workarounds now?
What exactly do you need for the downstream to make your life easier? ubuntu 24 or a specific linux distributable runnable on arm64 (deb,rpm,tar.gz,appimage)?
Yes, indeed. The userns stuff is for Ubuntu 24 (otherwise electron refuses to start in smoke tests) while the rest are for electron-builder/snapcraft/fpm.
I added those fixes mainly for the sake of completeness (i.e. artifact parity between x64 and arm64 linux). For Flatpak though, I guess having an AppImage is enough (the tar.gz doesn't contain a desktop file IIRC). I understand that keeping these workarounds can be a real burden. If building snap and deb/rpm isn't required right now for arm64, do you prefer removing those workarounds, and only keep AppImage + tar.gz for arm64 Linux? |
|
Let's keep this PR open for now to track when those workarounds are fixed upstream, and open a separate PR solely attempting to add AppImage to arm64 to get you unblocked. I think we would benefit from waiting on ubuntu24 for now, and we have no time pressure on snap/deb/rpm arm64 builds so those workarounds can be avoided too. |
|
Sounds good to me. I've opened #8331 to only enable AppImage for ARM64 Linux. |