Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: smoke failed in github action #8274

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Conversation

CurryYangxx
Copy link
Member

@CurryYangxx CurryYangxx commented Jan 6, 2025

The smoke test action failed in the ubuntu-latest image: https://github.com/Kong/insomnia/actions/runs/12629124914/job/35186437717

So we fixed the ubuntu image version to ubuntu-22.04 temporarily.
Consider reset after the issue is fixed: electron/electron#42510

@CurryYangxx CurryYangxx marked this pull request as draft January 6, 2025 07:11
@CurryYangxx CurryYangxx force-pushed the fix/github-action-smoke branch from 71ffcc8 to c1f6dc7 Compare January 6, 2025 07:46
@CurryYangxx CurryYangxx force-pushed the fix/github-action-smoke branch from 7c9133f to e650e7b Compare January 6, 2025 08:27
@CurryYangxx CurryYangxx marked this pull request as ready for review January 6, 2025 08:59
Copy link
Contributor

@ihexxa ihexxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update it back when our tests work for ubuntu 24.

@CurryYangxx CurryYangxx merged commit 18072a8 into develop Jan 6, 2025
8 checks passed
@CurryYangxx CurryYangxx deleted the fix/github-action-smoke branch January 6, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants