Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): failed to transform proxy port between sdk and renderer #8175

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Nov 15, 2024

Changes

  • Update the transforming logic between the sdk and the renderer
  • Disable some methods of the proxy-config class as they are not supported
  • Make port optional for the proxy-config as it could not be specified
  • Added some tests
  • Enable sentry reporting for script errors

The reported Eample: https://konghq.sentry.io/issues/6077030929/?environment=development&project=6311804&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&statsPeriod=90d&stream_index=1

Ref: #7976, INS-4636

@ihexxa ihexxa self-assigned this Nov 15, 2024
@ihexxa ihexxa marked this pull request as draft November 15, 2024 08:48
@ihexxa ihexxa changed the title fix(sdk): port failed to map between sdk and renderer fix(sdk): failed to transform proxy port between sdk and renderer Nov 15, 2024
@ihexxa ihexxa marked this pull request as ready for review November 20, 2024 07:41
@ihexxa ihexxa merged commit 12cb2fc into develop Nov 20, 2024
8 checks passed
@ihexxa ihexxa deleted the fix/sdk/proxy-map branch November 20, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants