Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): insomnia.variables.set should persist variables during runner execution period #8172

Merged
merged 3 commits into from
Nov 15, 2024
Merged

fix(cli): insomnia.variables.set should persist variables during runner execution period #8172

merged 3 commits into from
Nov 15, 2024
+30 −15

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Nov 14, 2024 •
edited
Loading

This change focuses on CLI.

Changes

  • Init transient variables in CLI runner
  • Wire transient variables up to the sendRequest and scriptExecutor

Ref: #8148, INS-4647

@ihexxa ihexxa self-assigned this Nov 14, 2024
@ihexxa ihexxa marked this pull request as draft November 14, 2024 08:10
@cwangsmv cwangsmv self-requested a review November 15, 2024 01:38
@ihexxa ihexxa marked this pull request as ready for review November 15, 2024 03:08
cwangsmv
cwangsmv reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@cwangsmv cwangsmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test local variables across different requests in the same runner and it works as expected

@ihexxa ihexxa merged commit 695d778 into develop Nov 15, 2024
8 checks passed
@ihexxa ihexxa deleted the fix/cli/transient-vars branch November 15, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwangsmv cwangsmv cwangsmv approved these changes

Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihexxa @cwangsmv