-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show proper error when environment variables are not valued [INS-3641] #7227
Conversation
I'd suggest extracting the common modal to a different PR, its unclear from the description why its required in this scope. |
"Execute anyways" (first letter upper case). |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good so far, note: nunjucks will remove the template when ignoring it. This is not easy to change, we would need to replace nunjucks, or send unrendered text rather than a partial render with the template removed.
@jackkav It is not easy to change.Now when user click the continue button, we will set the nunjucks throwOnUndefined config as true, so we can't perceived error and don't know if we need to use unrendered text.
I think that finding another template engine to replace Nunjucks would be better if necessary. |
Understood perhaps we can reconsider point 1 and 2 in the future. To be clear our option 1 trade off is as follows. I find either satisfactory for this PR scope however for users coming from postman, I think Unrendered would be less surprising. I'll leave it to your judgement whether to make this change in a future PR. |
c4ef514
to
8de39da
Compare
Related To INS-3641
This change is to give appropriate prompts when environment variables are missing, rather than directly displaying error messages.
Changes: