Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release-fedora to build fedora compatible RPM #5281

Closed

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented Oct 14, 2022

SEE UPDATE 23 January 2023


In this PR we add another job to the release-publish, release-fedora where we build Insomnia .rpm with buildDependenciesFromSource setting from within a fedora 36 container.

This helps provide a working workaround build that solves the issue folks are running into for #5088.

When we do builds with buildDependenciesFromSource set to true from within a Fedora 36 environment, we no longer get the SSL crash:

Screenshot 2022-10-14 at 11 46 03

TL;DR: Exploration to try and provide some sort of workaround for #5088

⚠️ This should probably not be solved in the insomnia build, what we’re doing is making it build node-libcurl from source which means it will be different from other platforms and not statically compiled. So it’ll have other potential issues depending on the environment it’s ran on, and not necessarily behave the same as other platforms. The proper solution is probably to change the build of the prebuilt node-libcurl binaries so they’re compatible instead.

@filfreire filfreire force-pushed the spike/fedora-build-exploration branch from 8749c17 to f7e5813 Compare October 14, 2022 11:33
@filfreire filfreire force-pushed the spike/fedora-build-exploration branch from f7e5813 to bac6e22 Compare October 19, 2022 15:20
@filfreire filfreire self-assigned this Oct 20, 2022
@filfreire filfreire force-pushed the spike/fedora-build-exploration branch 2 times, most recently from 7364a27 to 81651ed Compare October 21, 2022 14:47
@filfreire filfreire requested review from a team and removed request for DMarby October 21, 2022 15:24
@filfreire filfreire marked this pull request as ready for review October 21, 2022 15:24
@filfreire filfreire force-pushed the spike/fedora-build-exploration branch from 2e8f91e to 69b8bc7 Compare October 21, 2022 15:24
@filfreire filfreire marked this pull request as draft October 21, 2022 15:42
@filfreire filfreire force-pushed the spike/fedora-build-exploration branch from 69b8bc7 to abb50f3 Compare October 25, 2022 08:17
@azzamsa
Copy link

azzamsa commented Oct 28, 2022

Is this fixes will land on master?
I can't upgrade other packages because of pinned version of cups.

Thanks for insomnia! ❤️

@filfreire filfreire force-pushed the spike/fedora-build-exploration branch 3 times, most recently from 3579891 to e11da85 Compare November 4, 2022 13:11
@filfreire filfreire force-pushed the spike/fedora-build-exploration branch 2 times, most recently from 6d7dc8e to 8c09307 Compare November 16, 2022 17:57
@leonardehrenfried
Copy link

By the way, I tried the artifact from here: https://github.com/Kong/insomnia/actions/runs/3481857586

I still see the SSL connect error followed by a crash.

@filfreire filfreire force-pushed the spike/fedora-build-exploration branch from 8c09307 to bcf60ee Compare November 24, 2022 15:15
@filfreire filfreire marked this pull request as ready for review November 24, 2022 16:02
@filfreire
Copy link
Member Author

Hi @azzamsa @leonardehrenfried , while we don't have a more definitive solution, in order to unblock you in the meantime, I've compiled an experimental build on my fork which you can download and use:

https://github.com/filfreire/insomnia/releases/tag/fedora-experiment%408ae4fe71

Contains changes up to 8ae4fe71 and was built using: #5281

Please let me know if you have any issues with it.

@leonardehrenfried
Copy link

@filfreire I just upgraded all of my dependencies and re-installed the build you provided. I can now indeed use insomnia again! Thank you for this.

This will be good enough for me for a while.

@filfreire filfreire force-pushed the spike/fedora-build-exploration branch from a010b61 to 83f5cbc Compare December 15, 2022 16:55
@filfreire filfreire force-pushed the spike/fedora-build-exploration branch 2 times, most recently from 5378869 to 1aa7995 Compare January 16, 2023 13:22
@filfreire filfreire changed the title [spike] exploration on building and publish rpm with deps built from sources Add release-fedora to build fedora compatible RPM Jan 16, 2023
@filfreire filfreire force-pushed the spike/fedora-build-exploration branch from 71a919e to 5aeb0fb Compare January 20, 2023 16:00
@filfreire filfreire force-pushed the spike/fedora-build-exploration branch from 5aeb0fb to 3ddd65d Compare January 20, 2023 16:10
@filfreire
Copy link
Member Author

@filfreire filfreire closed this Jan 25, 2023
@filfreire filfreire deleted the spike/fedora-build-exploration branch January 25, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants