Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: client apis to interact with the konnect applications #490

Merged
merged 16 commits into from
Dec 12, 2024

Conversation

reversearrow
Copy link
Contributor

@reversearrow reversearrow commented Dec 10, 2024

Add Client APIs to interact with the Konnect Applications.

@reversearrow reversearrow changed the title feat: konnect application auth client apis feat: client apis to interact with the konnect applications Dec 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 28 lines in your changes missing coverage. Please review.

Project coverage is 55.16%. Comparing base (2ca5c65) to head (2b749ce).

Files with missing lines Patch % Lines
kong/konnect_application_service.go 54.83% 19 Missing and 9 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #490   +/-   ##
=======================================
  Coverage   55.15%   55.16%           
=======================================
  Files          71       72    +1     
  Lines        5691     5754   +63     
=======================================
+ Hits         3139     3174   +35     
- Misses       1935     1954   +19     
- Partials      617      626    +9     
Flag Coverage Δ
2.1 33.03% <1.58%> (-0.35%) ⬇️
2.2 43.39% <1.58%> (-0.47%) ⬇️
2.3 43.95% <1.58%> (-0.47%) ⬇️
2.4 44.02% <1.58%> (-0.47%) ⬇️
2.5 44.02% <1.58%> (-0.47%) ⬇️
2.6 44.02% <1.58%> (-0.47%) ⬇️
2.7 45.48% <1.58%> (-0.49%) ⬇️
2.8 45.48% <1.58%> (-0.49%) ⬇️
3.0 48.99% <1.58%> (-0.53%) ⬇️
3.1 50.31% <1.58%> (-0.54%) ⬇️
3.2 50.31% <1.58%> (-0.54%) ⬇️
3.3 50.31% <1.58%> (-0.54%) ⬇️
3.4 52.31% <1.58%> (-0.57%) ⬇️
3.5 50.48% <1.58%> (-0.55%) ⬇️
3.6 51.07% <55.55%> (+0.04%) ⬆️
3.7 51.07% <55.55%> (+0.04%) ⬆️
3.8 52.65% <55.55%> (+0.03%) ⬆️
community 41.17% <1.58%> (-0.44%) ⬇️
enterprise 53.77% <55.55%> (+0.01%) ⬆️
integration 55.16% <55.55%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pmalek

This comment was marked as off-topic.

@reversearrow reversearrow force-pushed the feat/konnect_applications branch from fb55339 to 78f5c55 Compare December 11, 2024 15:57
@reversearrow reversearrow marked this pull request as ready for review December 11, 2024 15:58
@reversearrow reversearrow requested review from a team as code owners December 11, 2024 15:58
@reversearrow reversearrow requested a review from pmalek December 11, 2024 15:59
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to add a changelog entry.

Other than those minor nits this looks good 👍

kong/konnect_application.go Outdated Show resolved Hide resolved
kong/konnect_application_service.go Outdated Show resolved Hide resolved
kong/konnect_application_service_test.go Outdated Show resolved Hide resolved
kong/konnect_application_service_test.go Show resolved Hide resolved
kong/konnect_application_service_test.go Show resolved Hide resolved
reversearrow and others added 7 commits December 11, 2024 12:19
Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
@reversearrow reversearrow requested a review from pmalek December 11, 2024 20:34
kong/konnect_application_service.go Outdated Show resolved Hide resolved
kong/konnect_application_service_test.go Outdated Show resolved Hide resolved
@reversearrow reversearrow requested a review from pmalek December 12, 2024 13:09
@pmalek pmalek merged commit c87a2a7 into main Dec 12, 2024
91 checks passed
@pmalek pmalek deleted the feat/konnect_applications branch December 12, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants