-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(*) add 1.9.0 changes #535
Conversation
Codecov Report
@@ Coverage Diff @@
## main #535 +/- ##
=======================================
Coverage 51.98% 51.98%
=======================================
Files 73 73
Lines 7714 7714
=======================================
Hits 4010 4010
Misses 3354 3354
Partials 350 350 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, each of these changes modifies existing behavior that may potentially be relied upon (per Hyrum's law).
Therefore I suggest that we bump the minor version number and release this as 1.9.0
, and replace "Fixed" with "Breaking changes" in the changelog.
8cfe7b7
to
cbd958a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the last round, I'm now convinced that the select-tags
change can be deemed a fix; I don't feel very comfortable doing so for the semantic change of error handling, but (as discussed in the inline comment) the impact is minimal (this is becoming an academic discussion) and not worth agonizing over it, so let it be.
Some minor release procedure comments attached.
Co-authored-by: Michał Flendrich <michal@flendrich.pro>
Co-authored-by: Michał Flendrich <michal@flendrich.pro>
* docs(*) add 1.8.3 changes Co-authored-by: Michał Flendrich <michal@flendrich.pro>
Add 1.8.3 changes and release instructions.
Small, but we haven't had a patch release in quite a while, and the error return is something we want in KIC sooner or later.
I also want to confirm the new CI stuff works in the actual deck repo and confirm if there's something I forgot that still requires manual work.
Added release instructions since we'd apparently forgotten to ever take them out of a Google Doc, and they've been stable for a while now.