-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kong2kic changes after code review #1218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging in to the kic
branch for final review
Aha! I'm not on @Kong/team-deck. Could someone please merge? This is targeting the |
looking at the commits, it should be rebased on the kic branch first. |
My battlebyt/kic fork is already in sync with Kong:kic branch, correct? |
My suggestion regarding dropping |
Doesn't look like it. If you look at the commits in this PR, they have a lot of work that is also in the base branch. |
Remove status and timestamp Linter and simplify Remove unused builders Simplify output generation deps update
@battlebyte I fixed the linter issues, and then accidentally merged this PR because its name is the same as the base branch. Please ensure you change the branch name next time. (if you have no other pending work, my suggestion would be to delete your clone and create a new one all together) |
This change incorporates the suggestions from
@Gabriele Gerbino
@travenichka
@michal
@Greg
The new command interface is: