fix: move professor name to sessions not course

KogoCampus · Feb 5, 2025 · 108248c · 108248c
1 parent 4cc3a51
commit 108248c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 21 deletions.
diff --git a/.env.example b/.env.example
diff --git a/app/agents/scrapers/simon_fraser_university.py b/app/agents/scrapers/simon_fraser_university.py
@@ -151,7 +151,6 @@ async def fetch_courses(self) -> CourseListingModel:
                 current_course: CourseModel = {
                     "courseName": course.get('title'),
                     "courseCode": f"{program['programCode']} {course.get('text')}",
-                    "professorName": None,
                     "credit": None,
                     "sessions": []
                 }
@@ -169,29 +168,31 @@ async def fetch_courses(self) -> CourseListingModel:
                     if not detail:
                         continue
 
-                    # Update course credit and professor if not set yet
-                    if current_course["credit"] is None and detail.get('info', {}).get('units'):
-                        current_course["credit"] = float(detail.get('info', {}).get('units'))
-
-                    if current_course["professorName"] is None:
-                        instructors = detail.get('instructor', [])
-                        if instructors:
-                            primary_instructor = next(
-                                (i for i in instructors if i.get('roleCode') == 'PI'),
-                                instructors[0] if instructors else None
-                            )
-                            if primary_instructor:
-                                current_course["professorName"] = primary_instructor.get('name')
-
                     # Create a new session for this section
                     current_session: SessionModel = {
                         "sessionName": f"{section.get('sectionCode', '')} {section.get('text', '')}".strip(),
+                        "professorName": None,
                         "campus": None,
                         "location": None,
                         "schedules": []
                     }
 
                     schedule_blocks = detail.get('courseSchedule', [])
+
+                    # Set professor name for this session
+                    instructors = detail.get('instructor', [])
+                    if instructors:
+                        primary_instructor = next(
+                            (i for i in instructors if i.get('roleCode') == 'PI'),
+                            instructors[0] if instructors else None
+                        )
+                        if primary_instructor:
+                            current_session["professorName"] = primary_instructor.get('name')
+
+                    # Update course credit if not set yet
+                    if current_course["credit"] is None and detail.get('info', {}).get('units'):
+                        current_course["credit"] = float(detail.get('info', {}).get('units'))
+
                     for block in schedule_blocks:
                         if block.get('isExam'):
                             continue