Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Generate pan_id for new installations #18530

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Aug 5, 2023

As discussed in #18357

Koenkk added a commit to zigbee2mqtt/hassio-zigbee2mqtt that referenced this pull request Aug 5, 2023
@Koenkk Koenkk merged commit cf313c5 into dev Aug 5, 2023
@Koenkk Koenkk deleted the feat/generate_pan_id branch August 5, 2023 11:22
@bharvey88
Copy link

just to confirm, you are also adding ext_pan_id auto generation now too right?

@Koenkk
Copy link
Owner Author

Koenkk commented Aug 6, 2023

No it's not generated (also don't think it is needed after reading https://community.silabs.com/s/article/what-is-an-extended-pan-id-and-how-is-it-used-x?language=en_US)

@bharvey88
Copy link

No it's not generated (also don't think it is needed after reading https://community.silabs.com/s/article/what-is-an-extended-pan-id-and-how-is-it-used-x?language=en_US)

In this documentation i do not see anything explicitly stating not to randomly generate it. Can you explain your reasoning why you believe it is not a good idea to randomly generate it? what is/are the downsides? - for reference - zha randomizes network_key, pan_id, and ext_pan_id and from what i understand there is no downside. Thanks.

@Koenkk
Copy link
Owner Author

Koenkk commented Aug 12, 2023

@bharvey88 I wasn't aware that ZHA also does this, so looks like a good practice. Implemented this in #18596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants