Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT message to request property on /get of a group fails #4564

Closed
TilmanK opened this issue Oct 5, 2020 · 2 comments
Closed

MQTT message to request property on /get of a group fails #4564

TilmanK opened this issue Oct 5, 2020 · 2 comments
Labels
problem Something isn't working

Comments

@TilmanK
Copy link
Contributor

TilmanK commented Oct 5, 2020

What happened

Reading properties via /get topic on MQTT fails, when used with a group.

#33[34mZigbee2MQTT:debug#033[39m 2020-10-05 18:05:23: Received MQTT message on 'zigbee2mqtt/Küche/Oberschränke/get' with data '{"brightness":255,"state":"on"}'
#33[34mZigbee2MQTT:debug#033[39m 2020-10-05 18:05:23: Publishing get 'get' 'state' to 'Küche/Oberschränke'
#33[31mZigbee2MQTT:error#033[39m 2020-10-05 18:05:23: Publish 'get' 'state' to 'Küche/Oberschränke' failed: 'TypeError: entity.read is not a function'
#33[34mZigbee2MQTT:debug#033[39m 2020-10-05 18:05:23: TypeError: entity.read is not a function
at Object.convertGet (/opt/zigbee2mqtt/node_modules/zigbee-herdsman-converters/converters/toZigbee.js:582:34)
at EntityPublish.onMQTTMessage (/opt/zigbee2mqtt/lib/extension/publish.js:262:37)
at Controller.callExtensionMethod (/opt/zigbee2mqtt/lib/controller.js:371:44)
at Controller.onMQTTMessage (/opt/zigbee2mqtt/lib/controller.js:268:14)
at MQTT.emit (events.js:315:20)
at MQTT.onMessage (/opt/zigbee2mqtt/lib/mqtt.js:94:14)
at MqttClient.emit (events.js:315:20)
at MqttClient._handlePublish (/opt/zigbee2mqtt/node_modules/mqtt/lib/client.js:1271:12)
at MqttClient._handlePacket (/opt/zigbee2mqtt/node_modules/mqtt/lib/client.js:410:12)
at work (/opt/zigbee2mqtt/node_modules/mqtt/lib/client.js:321:12)

What did you expect to happen

Either a useful error message or it works (maybe just read the requested property of the groups first device?)

How to reproduce it (minimal and precise)

Send a msg to zigbee2mqtt/[group_name]/get with proper formatted JSON payload.

Debug info

Zigbee2MQTT version: 1.15.0
Adapter hardware: CC2531, CC2530, CC26X2R1, CC1352P-2, Conbee II
Adapter firmware version:

@TilmanK TilmanK added the problem Something isn't working label Oct 5, 2020
Koenkk added a commit to Koenkk/zigbee-herdsman that referenced this issue Oct 6, 2020
@Koenkk
Copy link
Owner

Koenkk commented Oct 6, 2020

Fixed!

Changes will be available in the latest dev branch in a few hours (https://www.zigbee2mqtt.io/how_tos/how-to-switch-to-dev-branch.html)

@Koenkk Koenkk closed this as completed Oct 6, 2020
@TilmanK
Copy link
Contributor Author

TilmanK commented Oct 6, 2020

Nice, thank you ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants