-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Niko 552-721X2 - Non detection of the physical action of the switch #17749
Comments
I have the same issue, although I can't confirm that it worked on 1.29.x since I installed my Niko switch on 1.30.4. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days |
This issue still persists for me with version 1.32.1 |
Current version: 1.32.1-1 Got the same problem when running the switches in relay mode. This is what I get when pressing L1.
This is the same but then for off:
When I look into niko.js It looks like we have to look in these lines because the mqtt string is wrong.
And then it exposes this: It looks like the states are in ea.ALL right? |
Confirmed it works with v1.30.3, and misbehaves with v1.30.4 |
Reverting this single line seems to fix the problem (for this specific device): diff --git a/src/devices/niko.js b/src/devices/niko.js
index 400e43ab..acf1ad75 100644
--- a/src/devices/niko.js
+++ b/src/devices/niko.js
@@ -294,7 +294,8 @@ module.exports = [
endpoint: (device) => {
return {'l1': 1, 'l2': 2};
},
- meta: {multiEndpointEnforce: {'operation_mode': 1}},
+ meta: {multiEndpoint: true},
configure: async (device, coordinatorEndpoint, logger) => {
const ep1 = device.getEndpoint(1);
const ep2 = device.getEndpoint(2); Can anyone tell me what this change means? |
I can see the line you mention being changed back in this PR. Also looking through these changes, I noticed that I am having this prroblem with a Niko 552-721X1 instead of the 552-721X2 which this issue is about. For the 552-721X1 the Perhaps the |
I think you misunderstood me: the patch I pasted is the code I'm running now, so "master" niko.js but without the |
@sjorge since you made this change, could you take a look at this? |
I’ve not had the device in a while so those changes were from testing feedback from one of the issues here. From memory operating_mose in multiEndpointEnforce makes sense as both eps seem get changed together when setting ep1 (as they seemed to be linked), but setting it on ep2 had no effect but somehow still toggled the atteibute. It could be that the logic for multiEndpointEnforce itself is broken though. I think it got added specifically for the X2 variant. |
We might need:
|
Could you check if the issue is fixed with the following external converter: https://gist.github.com/Koenkk/e9be4bf02adbe6101c3781a3446e451f
external_converters:
- ext_converter.js
|
I did a quick test and it seems to work (to the extent that I'm using it) |
When not in control_relay mode, the "led_state" actions seem not useful. When in decoupled, they do the same thing, ie. switching either l1 or l2 on, both leds are turned (permanently) on on the switch, switching either l1 or l2 off turns the leds back off. In decoupled mode, I get the single, hold and release actions; in control_relay I don't get those actions... Unsure if this is expected? |
That would be expected, in control relay they toggle the relays. The device only reports new genOnOff.onOff state and z2m will update state_l<1|2> depending on which relay it was.When decoupled the device emits the manuNikoSwitch.switchAction report (i might have gotten the cluster name wrong, this is from memory) so z2m processes that and outputs the action event.The relay can still be toggled via z2m (device also reports the change when it has done so), sadly you can’t bind another remote to it.~ sjorgeOn 9 Aug 2023, at 20:22, Jo Vandeginste ***@***.***> wrote:
When not in control_relay mode, the "led_state" actions seem not useful. When in decoupled, they do the same thing, ie. switching either l1 or l2 on, both leds are turned (permanently) on on the switch, switching either l1 or l2 off turns the leds back off.
In decoupled mode, I get the single, hold and release actions; in control_relay I don't get those actions... Unsure if this is expected?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Thanks, I've integrated the fix. Changes will be available in the dev branch in a few hours from now. (https://www.zigbee2mqtt.io/advanced/more/switch-to-dev-branch.html) |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days |
What happened?
Hello,
Home Assistant (Last).
Version Z2M 1.29.2-1
For Double connectable switch - Niko - 552-721X2
Start, both switches are off.
Actuate L1 physically ->
info 2023-05-22 09:30:57MQTT publish: topic 'zigbee2mqtt/EclairageSalon02', payload '{"action_l1":null, "action_l2":null, "led_enable":true, "led_state": "OFF", "linkquality":72, "operation_mode": "control_relay", "operation_mode_l1":null, "operation_mode_l2":null, "state": "ON", "state_l1": "ON", "state_l2": "OFF"}'
-> Result OK
Version Z2M 1.30.4-1
Same procedure
info 2023-05-22 09:30:57MQTT publish: topic 'zigbee2mqtt/EclairageSalon02', payload '{"action_l1":null, "action_l2":null, "led_enable":true, "led_state": "OFF", "linkquality":72, "operation_mode": "control_relay", "operation_mode_l1":null, "operation_mode_l2":null, "state": "ON", "state_l1": "OFF", "state_l2": "OFF"}'
-> Result BAD
The action on the switch remains "state_l1":OFF
Sincerely
What did you expect to happen?
after push on l1 ->
info 2023-05-22 09:30:57MQTT publish: topic 'zigbee2mqtt/EclairageSalon02', payload '{"action_l1":null, "action_l2":null, "led_enable":true, "led_state": "OFF", "linkquality":72, "operation_mode": "control_relay", "operation_mode_l1":null, "operation_mode_l2":null, "state": "ON", "state_l1": "ON", "state_l2": "OFF"}'
How to reproduce it (minimal and precise)
No response
Zigbee2MQTT version
1.30.4-1
Adapter firmware version
CC1352P2_CC2652P_launchpad_coordinator_20220219
Adapter
Sonoff_Zigbee_3.0_USB_Dongle_Plus
Debug log
No response
The text was updated successfully, but these errors were encountered: