-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic support for EZSP 13 (gecko 4.4.0, ncp 7.4.0.0) #858
Conversation
Temporary disable backup
not full completed
@@ -611,7 +611,7 @@ class EZSPAdapter extends Adapter { | |||
} | |||
|
|||
public async supportsBackup(): Promise<boolean> { | |||
return true; | |||
return (this.driver && this.driver.ezsp && this.driver.ezsp.ezspV < 13); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What change causes the need for backup to be disabled (for version 13) here, or is the version is 0 based?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also return this.driver?.ezsp?.ezspV < 13
can make it more concise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What change causes the need for backup to be disabled (for version 13) here, or is the version is 0 based?
I disable backup for ezsp 13... Receiving keys and storing them still needs to be worked out.
in any case, even if there is a backup, it is not restored yet - I have not yet completed the correct restoration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What change causes the need for backup to be disabled (for version 13) here, or is the version is 0 based?
@kirovilya @xconverge Note! "This release of EmberZNet drops support for reading/writing network keys using our existing methods, breaking compatibility. The new commands thankfully maintain feature parity and include new features, allowing us to fully restore APS link keys." This might break backup and restore features. More info posted by puddly here -> zigpy/bellows#603
can be merged. the current code may already work. without backup |
Awesome, many thanks for the super quick update! |
Thanks a lot @kirovilya ! |
No description provided.