-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Move ZclFrame.fromBuffer()
out of adapter code
#1011
Conversation
A few more suggestions...
/** Returns the amount of bytes used by this header */
get length(): number {
return 3 + (this.manufacturerCode === null ? 0 : 2);
}
get isGlobal(): boolean {
return this.frameControl.frameType === FrameType.GLOBAL;
}
get isSpecific(): boolean {
return this.frameControl.frameType === FrameType.SPECIFIC;
}
|
All done! Let me know if this is OK now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Move the
ZclFrame.fromBuffer()
out of adapter code to prepare for custom cluster definitions as discussed in #971