Skip to content

Commit

Permalink
feat: Ember: change default APS options to follow silabs impl. (#1065)
Browse files Browse the repository at this point in the history
  • Loading branch information
Nerivec authored May 18, 2024
1 parent b258dfa commit 6408a05
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
6 changes: 2 additions & 4 deletions src/adapter/ember/adapter/emberAdapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -368,13 +368,11 @@ const STACK_CONFIGS = {
};

/**
* NOTE: This from SDK is currently ignored here because of issue in below link:
* NOTE: This from SDK:
* - BUGZID 12261: Concentrators use MTORRs for route discovery and should not enable route discovery in the APS options.
* - https://community.silabs.com/s/question/0D58Y00008DRfDCSA1/coordinator-cant-send-unicast-to-sleepy-node-after-reboot?language=en_US
*
* No issue have been linked to this at the moment, so keeping ENABLE_ROUTE_DISCOVERY just in case...
*/
const DEFAULT_APS_OPTIONS = (EmberApsOption.RETRY | EmberApsOption.ENABLE_ROUTE_DISCOVERY | EmberApsOption.ENABLE_ADDRESS_DISCOVERY);
const DEFAULT_APS_OPTIONS = (EmberApsOption.RETRY | EmberApsOption.ENABLE_ADDRESS_DISCOVERY);
/**
* Enabling this allows to immediately reject requests that won't be able to get to their destination.
* However, it causes more NCP calls, notably to get the source route overhead.
Expand Down
4 changes: 2 additions & 2 deletions src/adapter/ember/adapter/requestQueue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class EmberRequestQueue {
public stopDispatching(): void {
this.dispatching = false;

logger.debug(`Dispatching stopped; queue=${this.queue.length} priorityQueue=${this.priorityQueue.length}`, NS);
logger.info(`Request dispatching stopped; queue=${this.queue.length} priorityQueue=${this.priorityQueue.length}`, NS);
}

/**
Expand All @@ -61,7 +61,7 @@ export class EmberRequestQueue {

setTimeout(this.dispatch.bind(this), 0);

logger.debug(`Dispatching started.`, NS);
logger.info(`Request dispatching started.`, NS);
}

/**
Expand Down

0 comments on commit 6408a05

Please sign in to comment.