feat(add): MiBoxer TR-C1ZR dimmer https://github.com/Koenkk/zigbee2mq… #7638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Jun 15, 2024
Koenkk
reviewed
Jun 15, 2024
Koenkk
reviewed
Jun 15, 2024
src/lib/tuya.ts
Outdated
| @@ -1684,8 +1693,8 @@ const tuyaModernExtend = { | |||
| return tuyaModernExtend.dpEnumLookup({name: 'power_on_behavior', lookup: lookup, type: dataTypes.enum, | |||
| expose: e.power_on_behavior(Object.keys(lookup)).withAccess(readOnly ? ea.STATE : ea.STATE_SET), ...args}); | |||
| }, | |||
| tuyaLight(args?: modernExtend.LightArgs & {minBrightness?: boolean, switchType?: boolean}) { | |||
| args = {minBrightness: false, powerOnBehavior: false, switchType: false, ...args}; | |||
| tuyaLight(args?: modernExtend.LightArgs & {minBrightness?: boolean, minBrightness2?: boolean, switchType?: boolean}) { | |||
There was a problem hiding this comment.
Suggested change
| tuyaLight(args?: modernExtend.LightArgs & {minBrightness?: boolean, minBrightness2?: boolean, switchType?: boolean}) { | |
| tuyaLight(args?: modernExtend.LightArgs & {minBrightness?: 'attribute' | 'command', switchType?: boolean}) { |
There was a problem hiding this comment.
I added also "none" for devices that cannot set minimum brightness. Not sure if that is right.
Koenkk
reviewed
Jun 15, 2024
|
Thanks for the suggestions. I updated the commit. I was able to capture the attribute that the Tuya gateway is requesting and I could add it to Z2M, but strangely the response contains the value in the position of the data type, causing errors like: With the |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to add support for the MiBoxer dimmer requested in Koenkk/zigbee2mqtt#19141.
It depends on Koenkk/zigbee-herdsman#1090.
I'm not sure if it this is the right approach. I don't really know what I'm doing here. At least one missing piece is reading the minimum brightness back. Suggestions welcome.