adding support for sowilo device #6191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Sep 23, 2023
src/devices/sowilo.ts
Outdated
| vendor: 'Sowilo DS', | ||
| description: 'Heimdall Pro. 5 channel RGBWW controller.', | ||
| extend: extend.light_onoff_brightness_colortemp_color({supportsHueAndSaturation: true, colorTempRange: [150, 575]}), | ||
| ota: ota.zigbeeOTA, |
There was a problem hiding this comment.
I don't think we have an ota available for this device so please remove it.
There was a problem hiding this comment.
what's the procedure for OTAs ? I'm gonna remove this for now, but I can publish OTA files for this device.
There was a problem hiding this comment.
Ah great, you can add it here: https://github.com/Koenkk/zigbee-OTA
|
Note to self; after this merge Koenkk/zigbee2mqtt.io#2230 |
|
This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Somehow missed this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to add support for Sowilo DS's Heimdall Pro. You can see it here: https://sowilodesign.com/collections/frontpage/products/heimdall-pro-led-controller.
I tested locally and confirmed it's working.