Koenkk/zigbee2mqtt#12952: TS110E_2gang - add power_on_behavior and switch_type parameters
#4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figure switches type
…w to exclude `power_on_behavior` converters since they can conflict with manufacturer-specific ones
…figure `power_on_behavior`
…s_power_on_behavior` coverter with `tuya_switch_power_outage_memory` since we don't want to expose the `READ` capability (returns incorrect value)
… read command in the `configure` section
Koenkk
reviewed
Jun 29, 2022
lib/extend.js
Outdated
| tz.level_config, | ||
| ...(!options.disablePowerOnBehavior ? [tz.power_on_behavior] : []), | ||
| ...(!options.disableEffect ? [tz.effect] : []), | ||
| ]; |
There was a problem hiding this comment.
Please also add the disablePowerOnBehavior to other extend variants (e.g. light_onoff_brightness_color)
Koenkk
reviewed
Jun 29, 2022
…ry-and-switch-type
…_on_behavior` converters for the rest of light variants
|
@Koenkk updated |
|
Thanks! |
Mephistofeles
pushed a commit
to Mephistofeles/zigbee-herdsman-converters
that referenced
this pull request
Dec 13, 2022
…ang (Koenkk#4393) * Refs Koenkk/zigbee2mqtt#12952: `Lonsonho TS110E_2gang` - allow to configure switches type * Refs Koenkk/zigbee2mqtt#12952: `extend.light_onoff_brightness` - allow to exclude `power_on_behavior` converters since they can conflict with manufacturer-specific ones * Refs Koenkk/zigbee2mqtt#12952: `Lonsonho TS110E_2gang` - allow to configure `power_on_behavior` * Refs Koenkk/zigbee2mqtt#12952: `Lonsonho TS110E_2gang` - replace `moes_power_on_behavior` coverter with `tuya_switch_power_outage_memory` since we don't want to expose the `READ` capability (returns incorrect value) * Refs Koenkk/zigbee2mqtt#12952: `Lonsonho TS110E_2gang` - remove extra read command in the `configure` section * Refs Koenkk/zigbee2mqtt#12952: fix linter errors * Refs Koenkk/zigbee2mqtt#12952: revert formatting changes * Refs Koenkk/zigbee2mqtt#12952: `lib/extend` - allow to exclude `power_on_behavior` converters for the rest of light variants * Update lonsonho.js * Update fromZigbee.js * Update toZigbee.js * Update lonsonho.js Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Koenkk/zigbee2mqtt#12952