-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for various ZGP devices #2980
Conversation
- EnOcean PTM 215Z (FoH) - EnOcean PTM 215ZE - EnOcean PTM 216Z - Philips Hue Tap - Legrand ZLGP15 - Legrand ZLGP17 - Legrand ZLGP18
Note to self: after this merge Koenkk/zigbee2mqtt.io#888 |
Thanks! |
1 similar comment
Thanks! |
I am not sure if is actually possible to assign the devices to different vendors according to the ieeeAddr. I have two devices falling in this category with the addresses 0x00000000017119eb and 0x0000000024227604. They are actually by the vendor "Led Trading", but now the first one is identified as EnOcean device (https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/devices/enocean.js#L7) and the other one is not working anymore. The correct device was added with d6444cd but the prefix does not match. Are you sure that the address prefixes actually can be used in this case (then it would be the fault of Led Trading to assign wrong addresses - we still need an idea how to handle this...) or are the address prefixes just an assumption from the observation of a few devices? |
The source address prefixes and device IDs used in this PR are confirmed by EnOcean. |
@fredericseiler Thanks a lot for the hint! Then apparently other vendors (at least Led Trading) do not really care about using always the same (or at least consistent) addresses. Any idea how we can handle this? Is there at least a way to have a fallback (i.e. handle all devices with addresses that do not match any other devices as generic)? |
Well, the whole thing is clearly an issue for the CSA, but I'm pretty sure they're very busy with Matter and don't want to waste resources on ZGP open-source integration... |
Main issue Koenkk/zigbee-herdsman#398
This PR adds a
ieeeAddr
fingerprint filter to better identify ZGP devices.Also adds support for: