Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TuYa TS0216 Sound and flash siren with linear mapped volume #2631

Merged
merged 3 commits into from
May 29, 2021
Merged

TuYa TS0216 Sound and flash siren with linear mapped volume #2631

merged 3 commits into from
May 29, 2021

Conversation

iglu-sebastian
Copy link
Contributor

For mine with manufacturerName _TYZB01_0wcfvptl this is needed as volume seems to be a linear function as described in the commits.

@iglu-sebastian
Copy link
Contributor Author

iglu-sebastian commented May 28, 2021

@Koenkk if this has no other side effects it makes more user friendly to read.

@Koenkk
Copy link
Owner

Koenkk commented May 28, 2021

@iglu-sebastian is the range now from 0 - 100?

@iglu-sebastian
Copy link
Contributor Author

iglu-sebastian commented May 29, 2021

In original code my alarm was on max. volume when set to 10 and lowest volume set to 100. Anything below 10 the alarm stayed off.

Thought this makes it a bit user friendly.

EDIT: Yes, now the range is 0-100 with 0 the lowest and 100 the highest volume.

@Koenkk
Copy link
Owner

Koenkk commented May 29, 2021

Cool!

@Koenkk Koenkk merged commit a9a2635 into Koenkk:master May 29, 2021
@iglu-sebastian iglu-sebastian deleted the TS0216 branch June 9, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants