ubisys: Allow to configure device inputs using templates #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Oct 13, 2020
converters/toZigbee.js
Outdated
| if (value.hasOwnProperty('inputActions')) { | ||
| // example (default for C4): [[0,13,1,6,0,2], [1,13,2,6,0,2], [2,13,3,6,0,2], [3,13,4,6,0,2]] | ||
| await devMgmtEp.write('manuSpecificUbisysDeviceSetup', | ||
| {'inputActions': {elementType: 'octetStr', elements: value.inputActions}}); | ||
| } | ||
|
|
||
| if (value.hasOwnProperty('inputActionTemplates')) { |
There was a problem hiding this comment.
Thanks, can you make sure everything is snake case? e.g. inputActionTemplates -> input_action_templates.
Koenkk
reviewed
Oct 13, 2020
converters/toZigbee.js
Outdated
| inputActions = templateType.getInputActions(input, endpoint, template); | ||
| } else { | ||
| // scene(s) (always single input) | ||
| if (!template.hasOwnProperty('sceneId')) { |
There was a problem hiding this comment.
Also sceneId -> scene_id, groupId -> group_id.
|
Note to self; after this merge Koenkk/zigbee2mqtt.io#420 |
666d0cf to
2f9fd45
Compare
|
@Koenkk Should be ok like this, no? I also updated the docs PR accordingly. Only my branch name |
|
Perfect, thanks again! |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes general usage and especially direct ZigBee binding of the ubisys C4 a lot easier since there is no need anymore to dive into the raw input configuration attributes. It is also helpful for other ubisys devices to e.g. change the inputs from expecting push buttons to stationary switches.
Also see: Koenkk/zigbee2mqtt#3911 (comment)
Another PR for the documentation update will come in also in a few minutes.
Thanks,
Felix