Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS0043 different states for same device #1642

Closed
wants to merge 2 commits into from
Closed

TS0043 different states for same device #1642

wants to merge 2 commits into from

Conversation

arteck
Copy link
Contributor

@arteck arteck commented Oct 9, 2020

we need a standard state for ts0043 with or without a other manufacturerName

we need a standard state for ts0043 with or without a other manufacturerName
@Koenkk
Copy link
Owner

Koenkk commented Oct 9, 2020

Why is the current one not good? We should prevent to change this as it will lead to a breaking change.

@arteck
Copy link
Contributor Author

arteck commented Oct 10, 2020

we have a problem in iobroker with..

@Koenkk
Copy link
Owner

Koenkk commented Oct 10, 2020

Can you describe more of this problem?

@kirovilya
Copy link
Contributor

TS0043 model for devices with three buttons.
but with this model several manufacturers make devices.
and it is surprising that in one case the {action: 1_click} event arrives for a device with the TS0043 model, and if you take the same device from another manufacturer - you get {action: right_click}.
I believe that here it is necessary either to unify events for one device model, or to divide them into different device models.
another problem concerns iobroker.zigbee - we describe events for a device with separate entities, so we need to know what value will come to action for a specific device model. in the case of TS0043, we have a problem - the values ​​may be different.

I believe that it is better to bring the action value to one type, and not to divide by manufacturer.

@Koenkk
Copy link
Owner

Koenkk commented Oct 11, 2020

Thanks I understand your point now. In that case I propose to get rid of the whole if/else button mapping and always set buttonMapping to const buttonMapping = {1: '1', 2: '2', 3: '3', 4: '4'};

@kirovilya
Copy link
Contributor

I agree, we can remove the comparison with ManufacturerName

@arteck
Copy link
Contributor Author

arteck commented Oct 12, 2020

i make a new one

#1652

@arteck arteck closed this Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants