Fix wrong bitshift for Heiman battery status #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We forgot to fix the bitshift for the battery status. Sorry. @merlinschumacher
|
Should probably change the comment next to it as well. |
The comment is correct. If you shift the pointer of the first bit by three, you're at the fourth bit, which is the battery low indicator. |
qosmio
pushed a commit
to qosmio/zigbee-herdsman-converters
that referenced
this pull request
Dec 25, 2019
We forgot to fix the bitshift for the battery status. Sorry. @merlinschumacher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to fix the bitshift for the battery status. Sorry.
@merlinschumacher