fix(xiaomi_lock_report): improve conversion of key error messages #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Koenkk I have rebased my PR just to make sure this can be merged cleanly 😉 Btw, an off-topic: do you know of any tools for researching commands accepted by a device? The Vima lock is known to be configurable over ZigBee yet I'm clueless on how to discover what to put in |
|
Thanks! @aesedepece you should sniff the zigbee packets that the xiaomi gateways sends to the lock (http://www.inzoolee.com/capture-zigbee-packets/) |
|
Hey @qm3ster, by any chance, do you know what the Could there be multiple Vima Lock models sending slightly different action codes? |
|
I've never had one of these devices, just noticed this commit. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves conversion of key error messages so that they are properly returned.
It also makes a distinction between unknown keys (not registered) and disabled keys (explicitly disabled through Mi Home).
Seeing that @kirovilya originally added support for this lock, I suppose he should be able to review this PR and check if it works for him.
Fix #135